RE: [PATCH 2/7] crypto: sha256-mb - SHA256 multibuffer job manager and glue code

[Yu, Fenghua]

> From: Herbert Xu [mailto:herbert@xxxxxxxxxxxxxxxxxxx]
> Sent: Tuesday, April 05, 2016 5:04 AM
> To: megha.dey@xxxxxxxxxxxxxxx
> Cc: davem@xxxxxxxxxxxxx; linux-crypto@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; tim.c.chen@xxxxxxxxxxxxxxx; Yu, Fenghua
> <fenghua.yu@xxxxxxxxx>; Dey, Megha <megha.dey@xxxxxxxxx>
> Subject: Re: [PATCH 2/7] crypto: sha256-mb - SHA256 multibuffer job
> manager and glue code
> 
> On Thu, Mar 24, 2016 at 01:25:58PM -0700, megha.dey@xxxxxxxxxxxxxxx
> wrote:
> > From: Megha Dey <megha.dey@xxxxxxxxx>
> >
> > This patch introduces the multi-buffer job manager which is
> > responsible for submitting scatter-gather buffers from several SHA256
> > jobs to the multi-buffer algorithm. It also contains the flush routine
> > to that's called by the crypto daemon to complete the job when no new
> > jobs arrive before the deadline of maximum latency of a SHA256 crypto job.
> >
> > The SHA256 multi-buffer crypto algorithm is defined and initialized in
> > this patch.
> >
> > Signed-off-by: Megha Dey <megha.dey@xxxxxxxxxxxxxxx>
> > Reviewed-by: Fenghua Yu <fenghua.yu@xxxxxxxxx>
> > Reviewed-by: Tim Chen <tim.c.chen@xxxxxxxxxxxxxxx>
> 
> sha1-mb still has the same issues that I complained about for the aes-mb
> submission.  In particular, I don't like the use of shash to handle what is really
> an async implmentation.
> 
> So I'd like to see this fixed first before we add any more copies of this code.

We will update the patches and re-send out sha1/256/512 AVX2 mb algos using async implementation.

Thanks.

-Fenghua