RE: [PATCH -v2] drivers: net: ethernet: intel: e1000e: fix ethtool autoneg off for non-copper

[Brown, Aaron F]

> From: netdev-owner@xxxxxxxxxxxxxxx [mailto:netdev-
> owner@xxxxxxxxxxxxxxx] On Behalf Of Daniel Walker
> Sent: Tuesday, April 5, 2016 11:30 AM
> To: Ruinskiy, Dima <dima.ruinskiy@xxxxxxxxx>; Kirsher, Jeffrey T
> <jeffrey.t.kirsher@xxxxxxxxx>; Brandeburg, Jesse
> <jesse.brandeburg@xxxxxxxxx>; Nelson, Shannon
> <shannon.nelson@xxxxxxxxx>; Wyborny, Carolyn
> <carolyn.wyborny@xxxxxxxxx>; Skidmore, Donald C
> <donald.c.skidmore@xxxxxxxxx>; Allan, Bruce W <bruce.w.allan@xxxxxxxxx>;
> Ronciak, John <john.ronciak@xxxxxxxxx>; Williams, Mitch A
> <mitch.a.williams@xxxxxxxxx>
> Cc: Steve Shih <sshih@xxxxxxxxx>; xe-kernel@xxxxxxxxxxxxxxxxxx; Daniel
> Walker <dwalker@xxxxxxxxxx>; intel-wired-lan@xxxxxxxxxxxxxxxx;
> netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: [PATCH -v2] drivers: net: ethernet: intel: e1000e: fix ethtool autoneg
> off for non-copper
> 
> From: Steve Shih <sshih@xxxxxxxxx>
> 
> This patch fixes the issues for disabling auto-negotiation and forcing
> speed and duplex settings for the non-copper media.
> 
> For non-copper media, e1000_get_settings should return
> ETH_TP_MDI_INVALID for
> eth_tp_mdix_ctrl instead of ETH_TP_MDI_AUTO so subsequent
> e1000_set_settings
> call would not fail with -EOPNOTSUPP.
> 
> e1000_set_spd_dplx should not automatically turn autoneg back on for
> forced
> 1000 Mbps full duplex settings for non-copper media.
> 
> Cc: xe-kernel@xxxxxxxxxxxxxxxxxx
> Cc: Daniel Walker <dwalker@xxxxxxxxxx>
> Signed-off-by: Steve Shih <sshih@xxxxxxxxx>
> ---
>  drivers/net/ethernet/intel/e1000e/ethtool.c | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)

Tested-by: Aaron Brown <aaron.f.brown@xxxxxxxxx>