RE: [PATCH v2] gpio: pca953x: add PCAL9535 interrupt support for Galileo Gen2

[Li, Yong B]

Thanks Linus. I think the below patch(in fixes branch) should be merged into devel branch too, since the below patch is depended by this one in devel branch.

commit 9b8e3ec34318663affced3c14d960e78d760dd9a
Author: Yong Li <sdliyong@xxxxxxxxx>
Date:   Wed Mar 30 14:49:14 2016 +0800

    gpio: pca953x: Use correct u16 value for register word write

    The current implementation only uses the first byte in val,
    the second byte is always 0. Change it to use cpu_to_le16
    to write the two bytes into the register

    Cc: stable@xxxxxxxxxxxxxxx
    Signed-off-by: Yong Li <sdliyong@xxxxxxxxx>
    Reviewed-by: Phil Reid <preid@xxxxxxxxxxxxxxxxx>
    Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yong
> -----Original Message-----
> From: Linus Walleij [mailto:linus.walleij@xxxxxxxxxx]
> Sent: Friday, April 08, 2016 21:21
> To: Li, Yong B <yong.b.li@xxxxxxxxx>
> Cc: linux-gpio@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Alexandre
> Courbot <gnurou@xxxxxxxxx>; Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx>; Puustinen, Ismo
> <ismo.puustinen@xxxxxxxxx>; Phil Reid <preid@xxxxxxxxxxxxxxxxx>
> Subject: Re: [PATCH v2] gpio: pca953x: add PCAL9535 interrupt support for
> Galileo Gen2
> 
> n Thu, Apr 7, 2016 at 6:56 AM, Yong Li <yong.b.li@xxxxxxxxx> wrote:
> 
> > Galileo Gen2 board uses the PCAL9535 as the GPIO expansion, it is
> > different from PCA9535 and includes interrupt mask/status registers,
> > The current driver does not support the interrupt registers
> > configuration, it causes some gpio pins cannot trigger interrupt
> > events, this patch fix this issue. The original patch was submitted by
> > Josef Ahmad <josef.ahmad@xxxxxxxxxxxxxxx>
> > http://git.yoctoproject.org/cgit/cgit.cgi/meta-intel-quark/tree/recipe
> > s-kernel/linux/files/0015-Quark-GPIO-1-2-quark.patch
> >
> > Signed-off-by: Yong Li <yong.b.li@xxxxxxxxx>
> 
> Patch applied with Andy's review tag.
> 
> Yours,
> Linus Walleij