Re: [PATCH v3 0/8] block: prepare for multipage bvecs

From: Ming Lei
Date: Sun Apr 10 2016 - 23:32:04 EST


On Mon, Apr 4, 2016 at 2:56 PM, Ming Lei <ming.lei@xxxxxxxxxxxxx> wrote:
> Hi,
>
> Interests[1] have been shown in multipage bvecs, so this patchset
> try to prepare for the support and do two things:
>
> 1) the 1st 4 patches use bvec iterator to implement iterate_bvec(),
> then we can drop the non-standard way for iterating bvec, which
> can be thought as a good cleanup for lib/iov_iter.c
>
> 2) remove BIO_MAX_SECTORS & BIO_MAX_SIZE, and now there is only
> one user for each. Once multipage bvecs is introduced, one bio
> may hold lots of sectors, and we should always use sort of BIO_MAX_VECS
> which should be introduced in future and is similiar with current
> BIO_MAX_PAGES.
>
> xfstests(-a auto) have been run and no regression found by this
> patchset against linus v4.6-rc1-next-20160329.
>
> V3:
> - include kenrel.h & bug.h in bvec.h for fix comiling failure on arm
> as reported by 0day ktest
> - build test on arm & arm64
>
> V2:
> - rename bvec_iter.h as bvec.h
> - always include bvec.h into blk_types.h as suggested by Christoph
>
> V1:
> - don't move BIO_MAX_* to bvec_iter.h as pointed out by Christoph
> - run xfstests against v4.6-rc1-next-20160329
> - add Reviewed-by
> - for 1,4 and 5, Reviewd-by not added, Christoph still expressed
> 'this looks fine to me.'
>
> drivers/block/drbd/drbd_int.h | 4 +-
> fs/xfs/xfs_buf.c | 4 +-
> include/linux/bio.h | 52 -----------------------
> include/linux/blk_types.h | 22 +---------
> include/linux/bvec.h | 96 +++++++++++++++++++++++++++++++++++++++++++
> lib/iov_iter.c | 30 +++++---------
> 6 files changed, 110 insertions(+), 98 deletions(-)

Gentle ping...

Thanks,

>
>
> Thanks,
> Ming
>
>