Re: [PATCH] platform:x86 decouple telemetry driver from the optional IPC resources
From: Darren Hart
Date: Mon Apr 11 2016 - 02:52:00 EST
On Mon, Apr 11, 2016 at 04:04:55AM +0000, Chakravarty, Souvik K wrote:
>
>
> > -----Original Message-----
> > From: Zha, Qipeng
> > Sent: Monday, April 11, 2016 7:34 AM
> > To: Darren Hart <dvhart@xxxxxxxxxxxxx>; Aubrey Li
> > <aubrey.li@xxxxxxxxxxxxxxx>; Chakravarty, Souvik K
> > <souvik.k.chakravarty@xxxxxxxxx>
> > Cc: platform-driver-x86@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> > Subject: RE: [PATCH] platform:x86 decouple telemetry driver from the
> > optional IPC resources
> >
> > >> Currently the optional IPC resources prevent telemetry driver from
> > >> probing if these resources are not in ACPI table. This patch
> > >> decouples telemetry driver from these optional resources, so that
> > >> telemetry driver has dependency only on the necessary ACPI resources.
> > >>
> > >> Signed-off-by: Aubrey Li <aubrey.li@xxxxxxxxxxxxxxx>
> >
> > >Given the impact to their recent contributions, I'm looking for reviews from
> > Qipeng and Souvik before I merge this.
> >
> > >Qipeng, as the listed maintainer for these two files, I particularly need to
> > hear from you.
> >
> > >Thanks,
> >
> > Hi Darren, I think this is a reasonable solution for such issue.
> > Thanks Aubrey for this fixing patch.
>
> We went over this internally once. So OK from my POV.
Qipeng and Souvik, I appreciate the responses.
As a point of process, I won't include a "Reviewed-by:" unless you explicitly
include it in your response.
--
Darren Hart
Intel Open Source Technology Center