Re: [PATCH v6 07/10] usb: dwc3: gadget: Fix suspend/resume during dual-role mode

From: Felipe Balbi
Date: Mon Apr 11 2016 - 09:29:07 EST



Hi,

Roger Quadros <rogerq@xxxxxx> writes:
> On 11/04/16 15:23, Felipe Balbi wrote:
>>
>> Hi,
>>
>> Roger Quadros <rogerq@xxxxxx> writes:
>>> Gadget controller might not be always active during suspend/
>>> resume when we are operating in dual-role/otg mode.
>>> Check if we're active and only if we are then perform
>>> necessary actions during suspend/resume.
>>
>> I don't get this. If we're operating in OTG, we should have a gadget
>> driver loaded, no ?
>>
> At boot gadget driver is not automatically loaded. We're still in OTG mode
> but OTG state machine hasn't started.
> System suspend/resume can still happen.
>
> User might also load/unload the gadget driver prior to system suspend.

good point, this should go in the -rc too.

--
balbi

Attachment: signature.asc
Description: PGP signature