Re: [RFT v2] iommu/amd: use subsys_initcall() on amdv2 iommu

From: Christian KÃnig
Date: Mon Apr 11 2016 - 09:44:12 EST


Am 09.04.2016 um 02:25 schrieb Luis R. Rodriguez:
On Tue, Mar 29, 2016 at 10:41 AM, Luis R. Rodriguez <mcgrof@xxxxxxxxxx> wrote:
We need to ensure amd iommu v2 initializes before
driver uses such as drivers/gpu/drm/amd/amdkfd/kfd_module.c,
to do this make its init routine a subsys_initcall() which
ensures its load init is called first than modules when
built-in.

This reverts the old work around implemented through commit
1bacc894c227fad8a7 ("drivers: Move iommu/ before gpu/ in Makefile"),
instead of making the dependency implicit by linker order this
makes the ordering requirement explicit through proper kernel
APIs.

Cc: Oded Gabbay <oded.gabbay@xxxxxxx>
Cc: Christian KÃnig <christian.koenig@xxxxxxx>
Signed-off-by: Luis R. Rodriguez <mcgrof@xxxxxxxxxx>

Sorry for not responding earlier. Just coming back to all the stuff on my TODO list.

Patch is Acked-by: Christian KÃnig <christian.koenig@xxxxxxx>

Regards,
Christian.

*poke*

Luis