Re: [PATCH v8 3/3] irqchip: add nps Internal and external irqchips

From: Vineet Gupta
Date: Mon Apr 11 2016 - 10:10:09 EST


On Monday 11 April 2016 06:41 PM, Marc Zyngier wrote:
>> >> It doesn't mean I really approve of it. The default domain thing is
>> >> going to end-up biting you in the rear. But hey, better having this
>> >> supported upstream than leaving these patches up in the air...

Hi Marc,

Aside of this - there's been serious rework of ARC intc / timers code spurred by
some of your comments for this irqchip driver.

- We now probe timers via DT (so timer irq comes off of DT as well)
- We have now switched to linear irq domain (vs. legacy)

IMHO a bunch of ugliness / non-desirability remains (there's likely more)
- calling irq_set_default_host()
- calling irq_create_mapping with NULL for IPIs

I really want to do things in better way - make it more modern ... hence would
request you to please take a look at my latest series (I can post the patches here
if that helps - although it felt I was spamming you and you got pissed off or
something and were not responding of late :-)

git://git.kernel.org/pub/scm/linux/kernel/git/vgupta/arc.git #for-next

Pray tell me, what is not right and I'm all up for fixing it

Thx,
-Vineet