Re: [PATCH net v2] net: sched: do not requeue a NULL skb

From: Eric Dumazet
Date: Mon Apr 11 2016 - 10:22:44 EST


On Mon, 2016-04-11 at 15:38 +0200, Lars Persson wrote:

> I though it would be prudent because the queue can be non-empty even for
> the case of skb=NULL. So should it be there in this patch, another patch
> or not at all ?

Then maybe change return code ?

It seems strange that a validate_xmit_skb_list() failure stops the
__qdisc_run() loop but schedules another round.