Re: dm: ioctl: use kvfree

From: Sudip Mukherjee
Date: Mon Apr 11 2016 - 12:10:22 EST


On Monday 11 April 2016 08:47 PM, Mike Snitzer wrote:
On Mon, Apr 11 2016 at 11:14am -0400,
Sudip Mukherjee <sudipm.mukherjee@xxxxxxxxx> wrote:

We can use kvfree() instead of calling kfree() and vfree() based on
if-else and param_flags. kvfree() will check the type of address and
will call the respective function to free it.
Additionally we can also remove the use of DM_PARAMS_KMALLOC and
DM_PARAMS_VMALLOC.

Signed-off-by: Sudip Mukherjee <sudip.mukherjee@xxxxxxxxxxxxxxx>

Have you actually tested htis? Last time I looked to do this it exposed
crashes. I don't have time to dig into this again right now but this is
_not_ as simple as this patch implies.


No, it was just build tested. Is it possible to test it in qemu or kvm?

regards
sudip