Re: [PATCH 4.5 113/238] mtip32xx: Implement timeout handler

[Ben Hutchings]

On Sun, 2016-04-10 at 11:34 -0700, Greg Kroah-Hartman wrote:
> 4.5-stable review patch.ÂÂIf anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Asai Thambi SP <asamymuthupa@xxxxxxxxxx>
> 
> commit abb0ccd185c9e31847709b86192e6c815d1f57ad upstream.
> 
> Added timeout handler. Replaced blk_mq_end_request() with
> blk_mq_complete_request() to avoid double completion of a request.
> 
> Signed-off-by: Selvan Mani <smani@xxxxxxxxxx>
> Signed-off-by: Rajesh Kumar Sambandam <rsambandam@xxxxxxxxxx>
> Signed-off-by: Asai Thambi S P <asamymuthupa@xxxxxxxxxx>
> Signed-off-by: Jens Axboe <axboe@xxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> 
> ---
> Âdrivers/block/mtip32xx/mtip32xx.c |ÂÂÂ95 ++++++++++++++++++++++++++++++++++----
> Âdrivers/block/mtip32xx/mtip32xx.h |ÂÂÂÂ7 ++
> Â2 files changed, 92 insertions(+), 10 deletions(-)
[...]

This is >100 lines (the rough limit for stable), and it's part of a
whole series of complex and inadequately explained changes.

How thoroughly have these changes been tested against 4.4 and 4.5?

Ben.

-- 
Ben Hutchings
This sentence contradicts itself - no actually it doesn't.

Attachment: signature.asc
Description: This is a digitally signed message part