Re: mmotm woes, mainly compaction

From: Vlastimil Babka
Date: Tue Apr 12 2016 - 05:38:36 EST


On 04/12/2016 09:18 AM, Hugh Dickins wrote:
1. Fix crash in release_pages() from compact_zone() from kcompactd_do_work():
kcompactd needs to INIT_LIST_HEAD on the new freepages_held list.

Hmm, right. I didn't notice the new call site added by one series when rebasing the other series :/

4. Added VM_BUG_ONs to assert freepages_held is empty, matching those on
the other lists - though they're getting to look rather too much now.

I think the easiest thing to do for now is to drop from mmotm:
mm-compaction-direct-freepage-allocation-for-async-direct-compaction.patch
As Mel and Joonsoo didn't like it in the current state anyway.

6. Remove unused bool success from kcompactd_do_work().

That leaves just this part, which didn't fit anywhere else. I guess can just fold it to upcoming kcompactd patches?

Thanks for organizing my morning today, Hugh :)