Re: [PATCH] mfd: cros_ec: allow building for ARM64

From: Javier Martinez Canillas
Date: Tue Apr 12 2016 - 09:54:39 EST


Hello Lee,

On 04/12/2016 03:13 AM, Lee Jones wrote:
> On Mon, 11 Apr 2016, Javier Martinez Canillas wrote:
>> On 04/11/2016 12:42 PM, Brian Norris wrote:
>>> On Mon, Apr 11, 2016 at 09:48:49AM +0100, Lee Jones wrote:
>>>> When submitting patches, please use the format appropriate for the
>>>> subsystem.
>>>>
>>>> `git log --oneline -- <subsystem>` helps with this.
>>>
>>> $ git log --oneline --no-merges drivers/mfd/cros_ec*.c | head -10
>>> 8827a642a463 mfd: cros_ec_spi: Repair comparison ordering issue
>>> 2756db6c6366 mfd: cros_ec_i2c: Fix trivial 'tabs before spaces'
>>> whitespace issue.
>>> 6d6e44a95316 mfd: cros ec: Lock the SPI bus while holding chipselect
>>> 3821a065f567 spi: Drop owner assignment from spi_drivers
>>> 385c0012dfa0 mfd: cros_ec_i2c: Add OF match table
>>> a78ea195f77a mfd: cros_ec: spi: Add OF match table
>>> 0e777366fb0e mfd: Drop owner assignment from i2c_drivers
>>> cf649e00769a mfd: cros_ec: Staticise some newly introduced structures
>>> ff4378f4b813 mfd: cros_ec: spi: Add delay for asserting CS
>>> 57b33ff077be mfd: cros_ec: Support multiple EC in a system
>>>
>>> So...what's the problem with the subject?
>>>
>>
>> I also don't see what's wrong with the subject line...
>
> Then you're not looking hard enough.
>
> Every single patch description in the MFD subsystem starts with an
> uppercase character, just as you would any sentence.
>

Oh, I see. I didn't notice the difference indeed. Thanks a lot for
the clarification.

Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America