Re: [PATCH] arm64: dts: Add nodes for pdma0 and pdam1 for exynos7

From: Krzysztof Kozlowski
Date: Tue Apr 12 2016 - 10:06:11 EST


On 04/12/2016 02:49 PM, Alim Akhtar wrote:
> This patch adds device tree nodes for pdma0 and pdma1 controllers
> found on exynos7 SoCs.
>
> Signed-off-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>
> ---
> arch/arm64/boot/dts/exynos/exynos7.dtsi | 29 +++++++++++++++++++++++++++++
> 1 file changed, 29 insertions(+)
>

I would prefer avoid adding all new stuff at the end because it is
conflict-prone. Alphabetical order or by address... but none of these
are used currently. How about putting it after 'gic' node?

Anyway the code looks fine:
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>

Best regards,
Krzysztof