Re: [PART1 RFC v4 08/11] svm: Add VMEXIT handlers for AVIC

From: Paolo Bonzini
Date: Tue Apr 12 2016 - 18:29:21 EST




On 12/04/2016 18:22, Radim KrÄmÃÅ wrote:
>> > +
>> > + if (apic_id > 4 || cluster_id >= 0xf)
>> > + return NULL;
>> > + index = (cluster_id << 2) + apic_id;
> ffs(apic_id), because 'apic_id' must be compacted into 2 bits.
>

ffs(apic_id)-1 actually.

Thanks for the review, Radim.

Paolo