Re: [PATCH v4 5/6] fs: provide function to report enum strings

[Kees Cook]

On Tue, Apr 12, 2016 at 3:31 PM, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
> On Tue, Apr 12, 2016 at 09:54:44AM -0700, Kees Cook wrote:
>> Providing human-readable (and audit-parsable) strings for the READING_*
>> enums is needed by some LSMs.
>>
>> Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
>> ---
>>  fs/exec.c          | 19 +++++++++++++++++++
>>  include/linux/fs.h |  1 +
>>  2 files changed, 20 insertions(+)
>
> What the devil is that doing in fs/exec.c, of all places?

Since that's where the kernel_read* functions that use the enum live,
it seemed like the right place to put the string function too. I'm
happy to move it where ever folks think it's best to live.

-Kees

-- 
Kees Cook
Chrome OS & Brillo Security