Re: [PATCH] pmem: fix BUG() error in pmem.h:48 on X86_32

From: Dan Williams
Date: Wed Apr 13 2016 - 01:24:29 EST


On Tue, Apr 12, 2016 at 5:10 PM, Toshi Kani <toshi.kani@xxxxxxx> wrote:
> After 'commit fc0c2028135c ("x86, pmem: use memcpy_mcsafe()
> for memcpy_from_pmem()")', probing a PMEM device hits the BUG()
> error below on X86_32 kernel.
>
> kernel BUG at include/linux/pmem.h:48!
>
> memcpy_from_pmem() calls arch_memcpy_from_pmem(), which is
> unimplemented since CONFIG_ARCH_HAS_PMEM_API is undefined on
> X86_32.
>
> Fix the BUG() error by adding default_memcpy_from_pmem().
>
> Signed-off-by: Toshi Kani <toshi.kani@xxxxxxx>
> Cc: Dan Williams <dan.j.williams@xxxxxxxxx>
> Cc: Ross Zwisler <ross.zwisler@xxxxxxxxxxxxxxx>

Whoops, I'll add a 32-bit boot test to my release criteria. Thanks Toshi!