Re: [PATCH] drm/nouveau/iccsense: fix ifnullfree.cocci warnings

From: Karol Herbst
Date: Wed Apr 13 2016 - 06:14:22 EST




> Martin Peres <martin.peres@xxxxxxx> hat am 13. April 2016 um 09:55
> geschrieben:
>
>
> On 13/04/16 10:07, kbuild test robot wrote:
> > drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c:133:2-7: WARNING: NULL
> > check before freeing functions like kfree, debugfs_remove,
> > debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider
> > reorganizing relevant code to avoid passing NULL values.
> >
> > NULL check before some freeing functions is not needed.
> >
> > Based on checkpatch warning
> > "kfree(NULL) is safe this check is probably not required"
> > and kfreeaddr.cocci by Julia Lawall.
> >
> > Generated by: scripts/coccinelle/free/ifnullfree.cocci
> >
> > CC: Karol Herbst <nouveau@xxxxxxxxxxxxxx>
> > Signed-off-by: Fengguang Wu <fengguang.wu@xxxxxxxxx>
> Signed-off-by: Martin Peres <martin.peres@xxxxxxx>
Signed-off-by: Karol Herbst <nouveau@xxxxxxxxxxxxxx>