Re: [PATCH V2 3/5] gpio: of: Return error if gpio hog configuration failed

[Laxman Dewangan]

On Wednesday 13 April 2016 06:13 PM, Linus Walleij wrote:
> On Fri, Mar 11, 2016 at 2:43 PM, Laxman Dewangan <ldewangan@xxxxxxxxxx> wrote:
>
> > If GPIO hog configuration failed while adding OF based
> > gpiochip() then return the error instead of ignoring it.
> >
> > This helps of properly handling the gpio driver dependency.
> >
> > When adding the gpio hog nodes for NVIDIA's Tegra210 platforms,
> > the gpio_hogd() fails with EPROBE_DEFER because pinctrl is not
> > ready at this time and gpio_request() for Tegra GPIO driver
> > returns error. The error was not causing the Tegra GPIO driver
> > to fail as the error was getting ignored.
> >
> > Signed-off-by: Laxman Dewangan <ldewangan@xxxxxxxxxx>
> > Cc: Benoit Parrot <bparrot@xxxxxx>
> > Cc: Alexandre Courbot <acourbot@xxxxxxxxxx>
> > Reviewed-by: Thierry Reding <treding@xxxxxxxxxx>
> Rebased and applied this patch FWIW.
> This is a fair and square bug fix so need to go in
> no matter what happens with the hog patches.

Thank you very much for accepting the patch.
I think 1/5 and 2/5 is also fine as there is no more comment on this.


However, 4/5 and 5/5 needs further discussion.

Please let me know if I need to send 1/5 and 2/5 here.