Re: [PATCH v2] pinctrl: rockchip: add support the get_direction

[Linus Walleij]

On Tue, Mar 15, 2016 at 8:55 AM, Caesar Wang <wxt@xxxxxxxxxxxxxx> wrote:

> This patch adds the get_direction to support the gpio
> interface.
>
> The gpio direction is not used on rockchip platform when use the gpio
> debugfs.
>
> Tested on kylin board. (RK3036 SoCs)
> The repro steps:
> $/sys/class/gpio/
> echo 53 > export
> $/sys/class/gpio/gpio53# cat direction
> in
> In general, the gpio53 should be out value, but the direction is the
> default value 'in',  since the get_direction didn't supported in rockchip
> pinctrl.
>
> So, we should add this patch to support it.
>
> Reported-by: Jeffy Chen <jeffy.chen@xxxxxxxxxxxxxx>
> Signed-off-by: Caesar Wang <wxt@xxxxxxxxxxxxxx>
> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Cc: Heiko Stuebner <heiko@xxxxxxxxx>
> Cc: linux-gpio@xxxxxxxxxxxxxxx
> Cc: linux-rockchip@xxxxxxxxxxxxxxxxxxx
>
> ---
>
> Changes in v2:
> - As Heiko comments on (https://patchwork.kernel.org/patch/8576661/),
>   fixes the wrong offset from original patch.

Patch applied.

Yours,
Linus Walleij