Re: [PATCH v2 2/5] ext4: call dax_get_unmapped_area() for DAX pmd mappings

[Toshi Kani]

On Tue, 2016-04-12 at 23:01 -0400, Matthew Wilcox wrote:
> On Tue, Apr 12, 2016 at 02:39:29PM -0600, Toshi Kani wrote:
> > 
> > To support DAX pmd mappings with unmodified applications,
> > filesystems need to align an mmap address by the pmd size.
> > 
> > @@ -708,6 +708,9 @@ const struct file_operations ext4_file_operations =
> > {
> > Â	.open		= ext4_file_open,
> > Â	.release	= ext4_release_file,
> > Â	.fsync		= ext4_sync_file,
> > +#ifdef CONFIG_FS_DAX
> > +	.get_unmapped_area = dax_get_unmapped_area,
> > +#endif
> > Â	.splice_read	= generic_file_splice_read,
> > Â	.splice_write	= iter_file_splice_write,
> > Â	.fallocate	= ext4_fallocate,
>
> Could you do something like:
> 
> Â#ifdef CONFIG_FS_DAX
> Âstruct page *read_dax_sector(struct block_device *bdev, sector_t n);
> +unsigned long dax_get_unmapped_area(struct file *filp, unsigned long
> addr,
> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂunsigned long len, unsigned long pgoff, unsigned long
> flags);
> Â#else
> Âstatic inline struct page *read_dax_sector(struct block_device *bdev,
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂsector_t n)
> Â{
> ÂÂÂÂÂÂÂÂÂreturn ERR_PTR(-ENXIO);
> Â}
> +#define dax_get_unmapped_area	NULL
> Â#endif
> 
> in patch 1/5.ÂÂThen there's no need for the ifdefs in each filesystem.

I thought about it, but I do not think we can use an inline function to an
entry point.

Thanks,
-Toshi