Re: [PATCH v5 07/14] tools/lguest: force disable tboot and apm

From: Luis R. Rodriguez
Date: Wed Apr 13 2016 - 11:45:34 EST


On Wed, Apr 13, 2016 at 10:44:46AM +0200, Ingo Molnar wrote:
>
> * Luis R. Rodriguez <mcgrof@xxxxxxxxxx> wrote:
>
> > The paravirt_enabled() check is going away, the area tossed to
> > the kernel on lguest is not zerored out, so ensure lguest force
> > disables tboot and apm just in case the kernel file being read might
> > have this set for whatever reason.
> >
> > Signed-off-by: Luis R. Rodriguez <mcgrof@xxxxxxxxxx>
> > ---
> > tools/lguest/lguest.c | 6 ++++++
> > 1 file changed, 6 insertions(+)
>
> Yeah, so the v4 patch was acked by Rusty:
>
> Acked-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
>
> ... but you didn't add his ack to the v5 patch :-(

Sorry about that. Added.

> Please don't do this! Also please double check all past replies to make sure no
> acks got lost. I noticed this one, but there might be more.

I thought I had only left out the Acks for patches I later modified
significantly. Sorry. Will revise.

Luis