Re: [PATCH v3 08/15] dmaengine: dw: revisit data_width property

[Mark Brown]

On Wed, Apr 13, 2016 at 07:21:53PM +0300, Andy Shevchenko wrote:
> On Wed, 2016-04-13 at 21:47 +0530, Vinod Koul wrote:
> > On Wed, Apr 13, 2016 at 07:05:48PM +0300, Andy Shevchenko wrote:

> > > The old is still supported and benefit is apparently in unifying
> > > standard properties across the drivers.

> > Hrmmm how is that?

> The common usage for data-width property is "in bytes". And I like the
> idea. I don't know why at all I chose to keep encoded value there in the
> first place and no one commented at that time. I suppose because of
> screwed device tree process. I think now it's better to follow some
> standard / registered properties in new drivers.

You're unfortunately still breaking compatibility with existing DTs
using this property.  Now, it does appear that there is very little use
of this DMA controller on DT systems and judging by the somewhat odd
compatible string and in tree DTs most of those are legacy so perhaps
this isn't the end of the world but this isn't something that should be
dismissed as a simple cleanup.

Attachment: signature.asc
Description: PGP signature