Re: [PATCH v5 6/7] ARM: STiH407: Add nodes for RemoteProc

[Olof Johansson]

Hi,

On Tue, Jan 12, 2016 at 4:46 AM, Lee Jones <lee.jones@xxxxxxxxxx> wrote:
> Signed-off-by: Ludovic Barre <ludovic.barre@xxxxxx>
> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
> ---
>  arch/arm/boot/dts/stih407-family.dtsi | 40 +++++++++++++++++++++++++++++++++++
>  1 file changed, 40 insertions(+)
>
> diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi
> index 1e4e01925..15c20b6 100644
> --- a/arch/arm/boot/dts/stih407-family.dtsi
> +++ b/arch/arm/boot/dts/stih407-family.dtsi
> @@ -650,5 +650,45 @@
>                         mbox-name       = "st231_audio_video";
>                         status          = "okay";
>                 };
> +
> +               st231_gp0: st231-gp0@40000000 {

These node names seem odd. Should probably be more generic
"remoteproc@40000000".

> +                       compatible      = "st,st231-rproc";
> +                       reg             = <0x40000000 0x01000000>;

This isn't what the binding says, it uses a memory region instead.



-Olof