Re: [patch] ARM: qcom: silence an uninitialized variable warning
From: Arnd Bergmann
Date: Wed Apr 13 2016 - 21:53:30 EST
On Wednesday 13 April 2016, Dan Carpenter wrote:
> It's harmless but, if "enable" isn't set, then we pass uninitialized
> values to qcom_coincell_chgr_config(). The values aren't used, but
> let's silence the warning anyway.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
I haven't seen this warning in my tests, which means it probably doesn't show up
in the usual configurations. Are you sure this doesn't just happen with
CONFIG_PROFILE_ALL_BRANCHES, CONFIG_CC_OPTIMIZE_FOR_SIZE or CONFIG_GCOV_PROFILE_ALL,
or with versions of gcc before 4.9?
Arnd
> diff --git a/drivers/misc/qcom-coincell.c b/drivers/misc/qcom-coincell.c
> index 7b4a2da..829a61d 100644
> --- a/drivers/misc/qcom-coincell.c
> +++ b/drivers/misc/qcom-coincell.c
> @@ -94,7 +94,8 @@ static int qcom_coincell_probe(struct platform_device *pdev)
> {
> struct device_node *node = pdev->dev.of_node;
> struct qcom_coincell chgr;
> - u32 rset, vset;
> + u32 rset = 0;
> + u32 vset = 0;
> bool enable;
> int rc;
>
>