[PATCH 1/7] mmc: sdhci-pltfm: bail out if register resource is too small
From: Masahiro Yamada
Date: Wed Apr 13 2016 - 22:29:56 EST
This code checks the resource size and displays an error message if
it is too small, but still moves forward. Let is fail in that case.
Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
---
drivers/mmc/host/sdhci-pltfm.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c
index 072bb27..7d12203 100644
--- a/drivers/mmc/host/sdhci-pltfm.c
+++ b/drivers/mmc/host/sdhci-pltfm.c
@@ -127,8 +127,11 @@ struct sdhci_host *sdhci_pltfm_init(struct platform_device *pdev,
goto err;
}
- if (resource_size(iomem) < 0x100)
+ if (resource_size(iomem) < 0x100) {
dev_err(&pdev->dev, "Invalid iomem size!\n");
+ ret = -EINVAL;
+ goto err;
+ }
host = sdhci_alloc_host(&pdev->dev,
sizeof(struct sdhci_pltfm_host) + priv_size);
--
1.9.1