RE: [PATCH v4 2/2] usb: dwc3: add debugfs node to dump FIFO/Queue available space

[Du, Changbin]

Hello, Sergei,
> > From: "Du, Changbin" <changbin.du@xxxxxxxxx>
> >
> > For DWC3 USB controller, the Global Debug Queue/FIFO Space Available
> > Register(GDBGFIFOSPACE) can be used to dump FIFO/Queue available
> space.
> 
>     Space needed before (.

Okay.

> 
> > This can be used to check some special issues, like whether data is
> > successfully copied from memory to fifo when a trb is blocked.
> >
> > Signed-off-by: Du, Changbin <changbin.du@xxxxxxxxx>
> > ---
> > v4:
> >    Do not fail silently, but print error.
> [...]
> > diff --git a/drivers/usb/dwc3/debugfs.c b/drivers/usb/dwc3/debugfs.c
> > index 615d4dc..83e5bc1 100644
> > --- a/drivers/usb/dwc3/debugfs.c
> > +++ b/drivers/usb/dwc3/debugfs.c
> [...]
> > @@ -642,10 +681,15 @@ void dwc3_debugfs_init(struct dwc3 *dwc)
> >   	dwc->regset->nregs = ARRAY_SIZE(dwc3_regs);
> >   	dwc->regset->base = dwc->regs;
> >
> > +
> 
>     Why?

Thanks for point out, I will remove this additional line.

> 
> >   	file = debugfs_create_regset32("regdump", S_IRUGO, root, dwc-
> >regset);
> >   	if (!file)
> >   		dev_err(dwc->dev, "Can't create debugfs regdump\n");
> >
> > +	file = debugfs_create_file("fifo", S_IRUGO, root, dwc,
> &dwc3_fifo_fops);
> > +	if (!file)
> > +		dev_err(dwc->dev, "Can't create debugfs fifo\n");
> > +
> >   	if (IS_ENABLED(CONFIG_USB_DWC3_DUAL_ROLE)) {
> >   		file = debugfs_create_file("mode", S_IRUGO | S_IWUSR,
> root,
> >   				dwc, &dwc3_mode_fops);
> 
> MBR, Sergei