Re: [PATCH net v3] net: sched: do not requeue a NULL skb

From: David Miller
Date: Thu Apr 14 2016 - 01:29:42 EST


From: Lars Persson <lars.persson@xxxxxxxx>
Date: Tue, 12 Apr 2016 08:45:52 +0200

> A failure in validate_xmit_skb_list() triggered an unconditional call
> to dev_requeue_skb with skb=NULL. This slowly grows the queue
> discipline's qlen count until all traffic through the queue stops.
>
> We take the optimistic approach and continue running the queue after a
> failure since it is unknown if later packets also will fail in the
> validate path.
>
> Fixes: 55a93b3ea780 ("qdisc: validate skb without holding lock")
> Signed-off-by: Lars Persson <larper@xxxxxxxx>

Applied and queued up for -stable, thanks.