RE: [PATCH] qlge: Replace create_singlethread_workqueue with alloc_ordered_workqueue

[Manish Chopra]

> -----Original Message-----
> From: dept_hsg_linux_nic_dev-bounces@xxxxxxxxxxxxxxxxxxxxxxxx
> [mailto:dept_hsg_linux_nic_dev-bounces@xxxxxxxxxxxxxxxxxxxxxxxx] On Behalf
> Of Tejun Heo
> Sent: Wednesday, April 13, 2016 11:14 PM
> To: Amitoj Kaur Chawla <amitoj1606@xxxxxxxxx>
> Cc: Sudarsana Kalluru <Sudarsana.Kalluru@xxxxxxxxxx>; netdev
> <netdev@xxxxxxxxxxxxxxx>; linux-kernel <linux-kernel@xxxxxxxxxxxxxxx>; Dept-
> Eng Linux Driver <Linux-Driver@xxxxxxxxxx>; Harish Patil
> <harish.patil@xxxxxxxxxx>; Dept-GE Linux NIC Dev <Dept-
> GELinuxNICDev@xxxxxxxxxx>
> Subject: Re: [PATCH] qlge: Replace create_singlethread_workqueue with
> alloc_ordered_workqueue
> 
> On Sat, Apr 09, 2016 at 05:27:45PM +0530, Amitoj Kaur Chawla wrote:
> > Replace deprecated create_singlethread_workqueue with
> > alloc_ordered_workqueue.
> >
> > Work items include getting tx/rx frame sizes, resetting MPI processor,
> > setting asic recovery bit so ordering seems necessary as only one work
> > item should be in queue/executing at any given time, hence the use of
> > alloc_ordered_workqueue.
> >
> > WQ_MEM_RECLAIM flag has been set since ethernet devices seem to sit in
> > memory reclaim path, so to guarantee forward progress regardless of
> > memory pressure.
> >
> > Signed-off-by: Amitoj Kaur Chawla <amitoj1606@xxxxxxxxx>
> > Acked-by: Tejun Heo <tj@xxxxxxxxxx>
> 
> Ping?
> 

Hi,
Just want to confirm that __WQ_LEGACY flag is not necessary here as this is removed
with this change ? 

Thanks