Re: [PATCH 0/7] IB/hfi1: Remove write() and use ioctl() for user access
From: Jason Gunthorpe
Date: Thu Apr 14 2016 - 12:46:10 EST
On Thu, Apr 14, 2016 at 08:41:35AM -0700, Dennis Dalessandro wrote:
> This patch series removes the write() interface for user access in favor of an
> ioctl() based approach. This is in response to the complaint that we had
> different handlers for write() and writev() doing different things and expecting
> different types of data. See:
I think we should wait on applying these patches until we globally sort out
what to do with the rdma uapi.
It just doesn't make alot of sense for drivers to have their own personal
char devices. :(
A second char dev for the eeprom? How is that OK? Why aren't you using
the I2C layer for this?
Why is there a snoop interface in here? How is that not something that
belongs in a the core code?
Jason