Re: [PATCH v2] arm64/debug: Remove superfluous SMP function call

From: Will Deacon
Date: Thu Apr 14 2016 - 13:13:44 EST


On Wed, Apr 06, 2016 at 10:42:28AM +0200, Anna-Maria Gleixner wrote:
> Since commit 1cf4f629d9d2 ("cpu/hotplug: Move online calls to
> hotplugged cpu") it is ensured that callbacks of CPU_ONLINE and
> CPU_DOWN_PREPARE are processed on the hotplugged CPU. Due to this SMP
> function calls are no longer required.
>
> Replace smp_call_function_single() with a direct call to
> clear_os_lock(). The function writes the OSLAR register to clear OS
> locking. This does not require to be called with interrupts disabled,
> therefore the smp_call_function_single() calling convention is not
> preserved.
>
> Cc: Catalin Marinas <catalin.marinas@xxxxxxx>
> Cc: Will Deacon <will.deacon@xxxxxxx>
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Signed-off-by: Anna-Maria Gleixner <anna-maria@xxxxxxxxxxxxx>
> ---
> arch/arm64/kernel/debug-monitors.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)

Applied this and the hw_breakpoint one too, thanks.

Will