Re: [PATCH 1/7] soc/tegra: pmc: Use BIT macro for register field definition

[Linus Walleij]

On Tue, Apr 12, 2016 at 5:26 PM, Thierry Reding
<thierry.reding@xxxxxxxxx> wrote:

> Does this matter at all? We use the explicit notation in quite a number
> of places and it works great. I'd like to avoid needless churn unless
> there is a very good reason to switch.

I am softly enforcing <linux/bitops.h> in the GPIO subsystem
because I think it's a great perceptual aid, I can skim code
faster if this is used, easier for the brain to handle and thus
simplifies maintenance.

Others may disagree on its virtues.

It is not a subjective opinion, but proving the point needs
perceptual psychology research.

Yours,
Linus Walleij