Re: [PATCH v2 01/17] arm64: Reuse TCR field definitions for EL1 and EL2

[Will Deacon]

On Thu, Apr 14, 2016 at 02:20:49PM +0100, Suzuki K Poulose wrote:
> TCR_EL1, TCR_EL2 and VTCR_EL2, all share some field positions
> (TG0, ORGN0, IRGN0 and SH0) and their corresponding value definitions.
> 
> This patch makes the TCR_EL1 definitions reusable and uses them for TCR_EL2
> and VTCR_EL2 fields.
> 
> This also fixes a bug where we assume TG0 in {V}TCR_EL2 is 1bit field.
> 
> Cc: Catalin Marinas <catalin.marinas@xxxxxxx>
> Cc: Mark Rutland <mark.rutland@xxxxxxx>
> Cc: Will Deacon <will.deacon@xxxxxxx>
> Cc: Marc Zyngier <marc.zyngier@xxxxxxx>
> Reviewed-by: Christoffer Dall <christoffer.dall@xxxxxxxxxx>
> Signed-off-by: Suzuki K Poulose <suzuki.poulose@xxxxxxx>
> ---
>  arch/arm64/include/asm/kvm_arm.h       |   48 ++++++++++---------
>  arch/arm64/include/asm/pgtable-hwdef.h |   80 +++++++++++++++++++++++++-------
>  2 files changed, 88 insertions(+), 40 deletions(-)

Acked-by: Will Deacon <will.deacon@xxxxxxx>

Feel free to take this through the kvm-arm tree.

Will