Re: [PATCH v2 5/5] dax: handle media errors in dax_do_io

From: Dan Williams
Date: Fri Apr 15 2016 - 14:56:26 EST


On Fri, Apr 15, 2016 at 11:24 AM, Jeff Moyer <jmoyer@xxxxxxxxxx> wrote:
>> Moreover, we're going to do the full badblocks lookup anyway when we
>> call ->direct_access(). If we had that information earlier we can
>> avoid this fallback dance.
>
> None of the proposed approaches looks clean to me. I'll go along with
> whatever you guys think is best. I am in favor of wrapping up all that
> duplicated code, though.

Christoph originally pushed for open coding this fallback decision
per-filesystem. I agree with you on the "none the above" options are
clean.