Re: [PATCH v11 0/3] printk: Make printk() completely async

From: Joe Perches
Date: Sat Apr 16 2016 - 01:45:28 EST


On Sat, 2016-04-16 at 11:55 +0900, Sergey Senozhatsky wrote:
> On (04/08/16 02:31), Sergey Senozhatsky wrote:
> >
> > Hello,
> >
> > This patch set makes printk() completely asynchronous: new messages
> > are getting upended to the kernel printk buffer, but instead of 'direct'
> > printing the actual print job is performed by a dedicated kthread.
> > This has the advantage that printing always happens from a schedulable
> > context and thus we don't lockup any particular CPU or even interrupts.
> Hello,
>
> Sir, is there anything else you want me to improve in this patch set?

I'm not sir, but my preference would be to move as much of the
async/thread functionality as possible into a separate file.