Re: [PATCH 1/3] iio: core: Add devm_ APIs for iio_channel_{get,release}

From: Laxman Dewangan
Date: Sat Apr 16 2016 - 11:54:24 EST



On Saturday 16 April 2016 06:55 PM, Jonathan Cameron wrote:
On 10/04/16 18:35, Laxman Dewangan wrote:

Yaah, possibly race for very small time possible.

The limitation of devm_ api usage is that, we can keep using this
till we have devm_ api continuous and if some resource are not there
for devm_ then we can not use further. Possibly, I need to wait for
the devm_iio_channel_get() to merge and available for all subsystem
to use (next release) and then only I can use
devm_thermal_zone_of_sensor_register().

The alternative would be to merge this devm_ support as a prerequisite for your thermal
patches and have it go through that tree. As it's self contained I have
no particular problem with that if you'd prefer to do it that way.

Otherwise, you will need to do as you say above (not use
devm_thermal_zone_of_sensor_register) to make sure it isn't broken in the meantime.



I have recycled patch of thermal driver to not use devm_ for sensor registration.

I will post another patch in future once these changes will be available for all, most probably next release.

I think there is no further comment now on the series so you can consider for next step.

Thanks,
Laxman