Re: [PATCH] drm: msm: remove unused variable

From: Rob Clark
Date: Sat Apr 16 2016 - 16:49:14 EST


On Sat, Apr 16, 2016 at 4:41 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> A recent cleanup removed the only user of the 'kms' variable in
> msm_preclose(), causing a harmless compiler warning:
>
> drivers/gpu/drm/msm/msm_drv.c: In function 'msm_preclose':
> drivers/gpu/drm/msm/msm_drv.c:468:18: error: unused variable 'kms' [-Werror=unused-variable]
>
> This removes the variable as well.
>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> Fixes: 4016260ba47a ("drm/msm: fix bug after preclose removal")

thanks, I'll pull that in for 4.7.. danvet actually pointed that out
to me yesterday (a needed fix of a fix.. ;-))

BR,
-R

> ---
> drivers/gpu/drm/msm/msm_drv.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
> index c03b96709179..701c51ed3e7c 100644
> --- a/drivers/gpu/drm/msm/msm_drv.c
> +++ b/drivers/gpu/drm/msm/msm_drv.c
> @@ -465,7 +465,6 @@ static void msm_preclose(struct drm_device *dev, struct drm_file *file)
> {
> struct msm_drm_private *priv = dev->dev_private;
> struct msm_file_private *ctx = file->driver_priv;
> - struct msm_kms *kms = priv->kms;
>
> mutex_lock(&dev->struct_mutex);
> if (ctx == priv->lastctx)
> --
> 2.7.0
>