Re: [PATCH] spi: cadence: mark pm functions __maybe_unused
From: Shubhrajyoti Datta
Date: Mon Apr 18 2016 - 00:18:14 EST
On Sun, Apr 17, 2016 at 2:09 AM, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> The newly added runtime PM support for the cadence spi driver
> causes harmless warnings when PM is disabled:
> drivers/spi/spi-cadence.c:681:12: warning: 'cnds_runtime_suspend' defined but not used
> drivers/spi/spi-cadence.c:652:12: warning: 'cnds_runtime_resume' defined but not used
> This adds __maybe_unused annotations to the respective functions
> to shut up the warnings, while leaving the code in place for
> compile testing and avoiding ugly #ifdefs.
Thanks for the patch.
Feel free to add my ack.
Acked-by: Shubhrajyoti Datta <shubhraj@xxxxxxxxxx>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> Fixes: d36ccd9f7ea4 ("spi: cadence: Runtime pm adaptation")