Re: [PATCH 1/3] ARM: DTS: da850: add node for spi0
From: Sekhar Nori
Date: Mon Apr 18 2016 - 01:56:57 EST
On Friday 15 April 2016 09:47 PM, David Lechner wrote:
> On 04/15/2016 05:24 AM, Sekhar Nori wrote:
>
>>
>> This made me notice that num-cs is populated wrongly for spi1. It
>> actually has 8 chip selects. This is fine though.
>
> I might as well fix it since I have to make changes anyway. Don't
> remember how I came up with 6.
In section 3.7.7 of datasheet, there are 6 possible chip selects listed
for SPI0 and 8 possible chipselects for SPI1.
If you are fixing SPI1, please make that a separate patch.
>> Also, it will be nice to add pinctrl entries for spi0 like it is done
>> for spi1. You will need those anyway for using the interface.
>
> I omitted this on purpose. For my use case, I am using the SPI as
> write-only, so not using the SOMI pin, which is actually muxed as a GPIO
> for something else. So having a pinctl like spi1 is of no use to me. I
> figured if someone needs it, they can add it, otherwise it just is
> wasted space to me.
Alright, makes sense.
Regards,
Sekhar