Re: [PATCH] pata_artop: Use ioread8.

[Yoshinori Sato]

On Fri, 15 Apr 2016 00:45:17 +0900,
Tejun Heo wrote:
> 
> Hello,
> 
> On Thu, Apr 14, 2016 at 04:26:03PM +0900, Yoshinori Sato wrote:
> > Support for non x86 targets.
> 
> Being a bit more detailed would be nice.
> 
> > Signed-off-by: Yoshinori Sato <ysato@xxxxxxxxxxxxxxxxxxxx>
> > ---
> >  drivers/ata/pata_artop.c | 16 +++++++++++++---
> >  1 file changed, 13 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/ata/pata_artop.c b/drivers/ata/pata_artop.c
> > index 96c05c9..3731dea 100644
> > --- a/drivers/ata/pata_artop.c
> > +++ b/drivers/ata/pata_artop.c
> > @@ -340,6 +340,18 @@ static void atp8xx_fixup(struct pci_dev *pdev)
> >  	}
> >  }
> >  
> > +static int is_fast(struct pci_dev *pdev)
> 
> Can you please make the name a bit more descriptive?
> 
> Thanks.

OK.
I tried SuperH and ATP-865 system.
This CPU maps PCI IO space in memory window.
An address translation is needed by this CPU.
But inb not address translation. So can't access register.

> -- 
> tejun

-- 
Yoshinori Sato
<ysato@xxxxxxxxxxxxxxxxxxxx>