Re: [PATCHv2]brd: set max_discard_sectors properly
From: Jinpu Wang
Date: Mon Apr 18 2016 - 04:34:45 EST
On Sat, Apr 16, 2016 at 3:50 AM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
>> - blk_queue_max_discard_sectors(brd->brd_queue, UINT_MAX);
>> + blk_queue_max_discard_sectors(brd->brd_queue, UINT_MAX >> 9);
>
> Shouldn't we fix the issue by capping to UINT_MAX >> 9 inside
> blk_queue_max_discard_sectors? That way we'll prevent against having
> issues like this in any other driver as well.
Thanks Christoph, make sense to me, will rework it to this way.
Regards,
Jack