Re: [PATCH 0/7] IB/hfi1: Remove write() and use ioctl() for user access

[Dennis Dalessandro]

On Sat, Apr 16, 2016 at 08:19:17PM +0100, Al Viro wrote:

> While we are at it, could the person who'd come up with ui_lseek() be located
> and made to stand up and explain the rationale behind the SEEK_END semantics
> therein?  To quote the manpage (and paraphrase just about any introductory
> textbook):
>       SEEK_END
>              The file offset is set to the size of the file plus offset bytes.
>
> I'm really curious - which part of "plus" might have lead to
>        case SEEK_END:
>                offset = ((dd->kregend - dd->kregbase) + DC8051_DATA_MEM_SIZE) -
>                        offset;
> and, if its author has decided that of course it _must_ have meant "minus",
> why had he or she failed to post a correction to the manpage?  Or, on the

Original author of that code confirmed it is just a coding mistake and we 
will fix it.

-Denny