Re: [PATCH V2] net: ethernet: mellanox: correct page conversion

From: Christoph Hellwig
Date: Mon Apr 18 2016 - 09:11:06 EST


On Mon, Apr 18, 2016 at 09:06:18AM -0400, okaya@xxxxxxxxxxxxxx wrote:
> On 2016-04-18 08:12, Christoph Hellwig wrote:
> >On Sat, Apr 16, 2016 at 06:23:32PM -0400, Sinan Kaya wrote:
> >>Current code is assuming that the address returned by dma_alloc_coherent
> >>is a logical address. This is not true on ARM/ARM64 systems.
> >
> >Can you explain what you mean with a 'logical address' and what actual
> >issue you're trying to solve?
>
> Vmap call is failing on arm64 systems because dma alloc api already returns
> an address mapped with vmap.

Please state your problem clearly. What I'm reverse engineering from
your posts is: because dma_alloc_coherent uses vmap-like mappings on
arm64 (all, some systems?) a driver using a lot of them might run into
limits of the vmap pool size.

Is this correct?

>
> Please see arch/arm64/mm directory.
---end quoted text---