Re: [PATCH v2] carl9170: Clarify kconfig text
From: Christian Lamparter
Date: Mon Apr 18 2016 - 12:20:18 EST
On Monday, April 18, 2016 06:45:09 PM Kalle Valo wrote:
> Lauri Kasanen <cand@xxxxxxx> writes:
> > The previous text was confusing, leading readers to think this
> > driver was a duplicate, and so didn't need to be enabled.
> > After the removal of the older staging driver, this is the only
> > driver in mainline for these devices.
> > Signed-off-by: Lauri Kasanen <cand@xxxxxxx>
> > ---
> > v2: Remove the mention of the previous driver, suggested by Christian.
> > drivers/net/wireless/ath/carl9170/Kconfig | 8 +++-----
> > 1 file changed, 3 insertions(+), 5 deletions(-)
> > diff --git a/drivers/net/wireless/ath/carl9170/Kconfig b/drivers/net/wireless/ath/carl9170/Kconfig
> > index 1a796e5..2e34bae 100644
> > --- a/drivers/net/wireless/ath/carl9170/Kconfig
> > +++ b/drivers/net/wireless/ath/carl9170/Kconfig
> > @@ -5,12 +5,10 @@ config CARL9170
> > select FW_LOADER
> > select CRC32
> > help
> > - This is another driver for the Atheros "otus" 802.11n USB devices.
> > + This is the mainline driver for the Atheros "otus" 802.11n USB devices.
> > - This driver provides more features than the original,
> > - but it needs a special firmware (carl9170-1.fw) to do that.
> > -
> > - The firmware can be downloaded from our wiki here:
> > + It needs a special firmware (carl9170-1.fw), which can be downloaded
> > + from our wiki here:
> > <http://wireless.kernel.org/en/users/Drivers/carl9170>
> Why even mention anything about a "special firmware" as the firmware is
> already available from linux-firmware.git?
Yes and no. 1.9.6 is in linux-firmware.git. I've tried to add 1.9.9 too
but that failed.
> That's default location for all firmware images and I think most, if not all,
> distros should have it available. So wouldn't it be better not to mention
> anything about firmware at all?
Sure, but this could be a different patch then. I think Intel devices
(iwlwifi, iwlegacy and ipw2x00) have a similar text about "download
firmware from this device from our homepage here" too. So if we want,
we can remove them altogether?