Re: [PATCH V2 3/3] gpio: tegra: Add support for gpio debounce

[Thierry Reding]

On Tue, Apr 19, 2016 at 03:13:40PM +0530, Laxman Dewangan wrote:
[...]
> @@ -570,7 +612,14 @@ static struct tegra_gpio_soc_config tegra30_gpio_config = {
>  	.upper_offset = 0x80,
>  };
>  
> +static struct tegra_gpio_soc_config tegra210_gpio_config = {
> +	.bank_stride = 0x100,
> +	.upper_offset = 0x80,
> +	.debounce_supported = true,
> +};
> +
>  static const struct of_device_id tegra_gpio_of_match[] = {
> +	{ .compatible = "nvidia,tegra210-gpio", .data = &tegra210_gpio_config },
>  	{ .compatible = "nvidia,tegra30-gpio", .data = &tegra30_gpio_config },
>  	{ .compatible = "nvidia,tegra20-gpio", .data = &tegra20_gpio_config },
>  	{ },

I think I'd split this hunk off into a separate patch. Oh, and perhaps
follow up with a patch that makes the SoC configuration data const?

Thierry

Attachment: signature.asc
Description: PGP signature