Re: [PATCH 1/7] mmc: sdhci-pltfm: bail out if register resource is too small
From: Adrian Hunter
Date: Tue Apr 19 2016 - 09:32:04 EST
On 19/04/16 14:46, Masahiro Yamada wrote:
> Hi Adrian,
> 2016-04-19 20:32 GMT+09:00 Adrian Hunter <adrian.hunter@xxxxxxxxx>:
>> On 14/04/16 05:29, Masahiro Yamada wrote:
>>> This code checks the resource size and displays an error message if
>>> it is too small, but still moves forward. Let is fail in that case.
>> is -> it
>> How do you know there aren't drivers that actually have a smaller size?
> No, I do not know.
> This is an error message, so I think it should fail in that case.
> Maybe, can we drop this check completely?
Yes, I think so.