Re: [PATCH 3/5] perf script: fix postgresql ubuntu install instructions

From: Arnaldo Carvalho de Melo
Date: Tue Apr 19 2016 - 09:41:17 EST


Em Tue, Apr 19, 2016 at 01:56:02AM -0700, Chris Phlipot escreveu:
> The current instructions for setting up an Ubuntu system for using
> the export-to-postgresql.py script are incorrect.
>
> The instructions in the script have been updated to work on newer
> versions of ubuntu.
>
> -Add missing dependencies to apt-get command:
> python-pyside.qtsql, libqt4-sql-psql
> -Add '-s' option to createuser command to force the user to be a
> superuser since the command doesn't prompt as indicated in the
> current instructions.
>
> Tested on: Ubuntu 14.04, Ubuntu 16.04(beta)

Applied.

> Signed-off-by: Chris Phlipot <cphlipot0@xxxxxxxxx>
> ---
> tools/perf/scripts/python/export-to-postgresql.py | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/tools/perf/scripts/python/export-to-postgresql.py b/tools/perf/scripts/python/export-to-postgresql.py
> index 1b02cdc..6f0ca68 100644
> --- a/tools/perf/scripts/python/export-to-postgresql.py
> +++ b/tools/perf/scripts/python/export-to-postgresql.py
> @@ -34,10 +34,9 @@ import datetime
> #
> # ubuntu:
> #
> -# $ sudo apt-get install postgresql
> +# $ sudo apt-get install postgresql python-pyside.qtsql libqt4-sql-psql
> # $ sudo su - postgres
> -# $ createuser <your user id here>
> -# Shall the new role be a superuser? (y/n) y
> +# $ createuser -s <your user id here>
> #
> # An example of using this script with Intel PT:
> #
> --
> 2.7.4