Re: [RESEND PATCH v2 3/5] security: Introduce security_settime64()

[Serge E. Hallyn]

Quoting Kees Cook (keescook@xxxxxxxxxxxx):
> On Mon, Apr 18, 2016 at 9:54 AM, John Stultz <john.stultz@xxxxxxxxxx> wrote:
> > On Thu, Apr 7, 2016 at 11:02 PM, Baolin Wang <baolin.wang@xxxxxxxxxx> wrote:
> >> security_settime() uses a timespec, which is not year 2038 safe
> >> on 32bit systems. Thus this patch introduces the security_settime64()
> >> function with timespec64 type. We also convert the cap_settime() helper
> >> function to use the 64bit types.
> >>
> >> Move the security_settime() to the head file as a inline function for
> >> removing that inline helper when following up patches are fixed the
> >> call sites.
> >>
> >> None of the existing hooks is using the timespec argument and therefor
> >> the patch is not doing any functional changes.
> >>
> >> Signed-off-by: Baolin Wang <baolin.wang@xxxxxxxxxx>
> >
> > Hey Baolin,
> >   If you get an ack, like you did from James, please include it in the
> > commit message of following submissions
> >
> > Serge, Kees: Any objection to this patch going in via the
> > tip/timers/core tree with the dependent settimeofday64 call?
> 
> No problem from me: makes sense to keep it all together in one tree.

Sorry for the delayed response - sounds good to me.