Re: [Intel-wired-lan] [PATCH net-next V5 2/2] intel: ixgbevf: Support Windows hosts (Hyper-V)

[Jeff Kirsher]

On Tue, 2016-04-19 at 19:17 -0700, K. Y. Srinivasan wrote:
> On Hyper-V, the VF/PF communication is a via software mediated path
> as opposed to the hardware mailbox. Make the necessary
> adjustments to support Hyper-V.
> 
> Signed-off-by: K. Y. Srinivasan <kys@xxxxxxxxxxxxx>
> ---
> ÂÂÂÂÂÂÂÂV2: Addressed most of the comments from
> ÂÂÂÂÂÂÂÂÂÂÂ Alexander Duyck <alexander.duyck@xxxxxxxxx>
> ÂÂÂÂÂÂÂÂÂÂÂ and Rustad, Mark D <mark.d.rustad@xxxxxxxxx>.
> 
> ÂÂÂÂÂÂÂÂV3: Addressed additional comments from
> ÂÂÂÂÂÂÂÂÂÂÂ Alexander Duyck <alexander.duyck@xxxxxxxxx>
> 
> ÂÂÂÂÂÂÂÂV4: Addressed kbuild errors reported by:
> ÂÂÂÂÂÂÂÂÂÂÂ kbuild test robot <lkp@xxxxxxxxx>
> 
> ÂÂÂÂÂÂÂÂV5: Addressed additional comments from
> ÂÂÂÂÂÂÂÂÂÂÂ Alexander Duyck <alexander.duyck@xxxxxxxxx>

First I commend you on actually making a proper changelog for a patch.
ÂThe only issue I have is that the changelog provides not actual
changes. ÂSaying you reacted to comments does not summarize what the
actual changes were. ÂI purposely did not review the earlier versions
because by the time I went to do a review, there was another version
already submitted. ÂSo your changelog requires that users look at all
the previous emails to actually see what Alex and Mark requested in
changes.

I am telling you this for future patches, it will not impact these
patches, just really disappointing. ÂI will take the extra time to
track down all the previous emails and the changes requested to ensure
you made all the changes that were requested of you. :-( ÂThis will
just delay when I apply the patches for testing.

> 
> Âdrivers/net/ethernet/intel/ixgbevf/ixgbevf.hÂÂÂÂÂ |ÂÂ 12 ++
> Âdrivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c |ÂÂ 31 +++-
> Âdrivers/net/ethernet/intel/ixgbevf/mbx.cÂÂÂÂÂÂÂÂÂ |ÂÂ 12 ++
> Âdrivers/net/ethernet/intel/ixgbevf/vf.cÂÂÂÂÂÂÂÂÂÂ |Â 216
> +++++++++++++++++++++
> Âdrivers/net/ethernet/intel/ixgbevf/vf.hÂÂÂÂÂÂÂÂÂÂ |ÂÂÂ 2 +
> Â5 files changed, 266 insertions(+), 7 deletions(-)

Attachment: signature.asc
Description: This is a digitally signed message part