Re: [PATCHv1 0/6] leds: pca9653x: support inverted outputs and cleanups

From: Ricardo Ribalda Delgado
Date: Wed Apr 20 2016 - 04:57:22 EST


Hi

On Wed, Apr 20, 2016 at 10:51 AM, Olliver Schinagl <oliver@xxxxxxxxxxx> wrote:

>> As I said before, the reason for this proposal is that the code NEVER
>> clears PCA963X_MODE2_DMBLNK, only sets it.
>> Unfortunately I do not have the HW to test this change.
>
> The code never clears it, but the hardware does. So we have to set it
> everytime we enable blink.

Ok, that was the part I was missing. I was not aware that the hw was
clearing it.

Saving mode2 sounds like a good compromise then.

But I still believe that we should limit the lock to ledout. No matter
what we do, we cannot have two leds blinking at different frequencies
on the same chip.


Regards

--
Ricardo Ribalda